Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich Text: Add missing keep placeholder on focus prop documentation. #17445

Conversation

epiqueras
Copy link
Contributor

Description

This PR follows #17439 to add missing documentation for the keepPlaceholderOnFocus prop.

How has this been tested?

It was read, haha.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@epiqueras epiqueras added [Type] Developer Documentation Documentation for developers [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Package] Rich text /packages/rich-text labels Sep 15, 2019
@epiqueras epiqueras added this to the Future milestone Sep 15, 2019
@epiqueras epiqueras self-assigned this Sep 15, 2019
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Alternatively you could restore it from https://github.com/WordPress/gutenberg/pull/16733/files. Up to you :)

@epiqueras epiqueras merged commit 8cd6295 into master Sep 15, 2019
@epiqueras epiqueras deleted the add/missing-keep-placeholder-on-focus-rich-text-prop-documentation branch September 15, 2019 15:11
@gziolo
Copy link
Member

gziolo commented Sep 15, 2019

Cool, thank you!

It was read, haha.

Love it 🤣

@youknowriad youknowriad modified the milestones: Future, Gutenberg 6.5 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Package] Rich text /packages/rich-text [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants